Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754422AbYJAVhL (ORCPT ); Wed, 1 Oct 2008 17:37:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753620AbYJAVg7 (ORCPT ); Wed, 1 Oct 2008 17:36:59 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:38324 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753612AbYJAVg6 (ORCPT ); Wed, 1 Oct 2008 17:36:58 -0400 Date: Wed, 1 Oct 2008 22:36:45 +0100 From: Alan Cox To: Steven Noonan Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, Steven Noonan Subject: Re: [PATCH] drivers/serial/8250.c: 'i' may be used uninitialized Message-ID: <20081001223645.23ad0e5e@lxorguk.ukuu.org.uk> In-Reply-To: <1222850827-30522-1-git-send-email-steven@uplinklabs.net> References: <1222850827-30522-1-git-send-email-steven@uplinklabs.net> X-Mailer: Claws Mail 3.5.0 (GTK+ 2.12.12; x86_64-redhat-linux-gnu) Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a Lloegr o'r rhif cofrestru 3798903 Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 917 Lines: 21 On Wed, 1 Oct 2008 01:47:07 -0700 Steven Noonan wrote: > serial_unlink_irq_chain() does not initialize iterator 'i', and that is > correct logically because it is always initialized, either in the > hlist_for_each or in the conditional immediately after (which fires if > hlist_for_each comes up empty-handed). GCC does not realize this > connection and emits a false warning. Annotate it with uninitialized_var(). > > Signed-off-by: Steven Noonan Ok definitive NAK. gcc 4.3.0 can work this out and doesn't produce a warning. Thanks for sending the patch though (and to the gcc folks for rendering it unnecessary) Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/