Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754670AbYJBQR2 (ORCPT ); Thu, 2 Oct 2008 12:17:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753749AbYJBQRT (ORCPT ); Thu, 2 Oct 2008 12:17:19 -0400 Received: from palinux.external.hp.com ([192.25.206.14]:60797 "EHLO mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753601AbYJBQRS (ORCPT ); Thu, 2 Oct 2008 12:17:18 -0400 Date: Thu, 2 Oct 2008 10:17:01 -0600 From: Matthew Wilcox To: Jesse Barnes Cc: "Zhao, Yu" , "linux-pci@vger.kernel.org" , Randy Dunlap , Grant Grundler , Alex Chiang , Roland Dreier , Greg KH , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "virtualization@lists.linux-foundation.org" Subject: Re: [PATCH 3/6 v3] PCI: support ARI capability Message-ID: <20081002161701.GO13822@parisc-linux.org> References: <200810020903.16385.jbarnes@virtuousgeek.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200810020903.16385.jbarnes@virtuousgeek.org> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 864 Lines: 18 On Thu, Oct 02, 2008 at 09:03:15AM -0700, Jesse Barnes wrote: > Maybe we should be consistent with the other APIs and call it pci_enable_ari > (like we do for wake & msi). Looks pretty good otherwise. Those APIs are for drivers ... this is internal. I don't have any objection of my own, though I agree with Alex's remark that the printk is unnecessary and just adds clutter to the boot process. -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/