Date: Thu, 2 Oct 2008 20:33:30 +0300
From: "Kim B. Heino" <Kim.Heino@bluegiga.com>
To: "Bosko Radivojevic" <bosko.radivojevic@gmail.com>
Cc: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
       a.zummo@towertech.it
Subject: Re: [PATCH] add support for ST M41T94 SPI RTC (patch rev. 3)
Message-ID: <20081002203330.295ad5c0@why.bbbs.net>
In-Reply-To: <d6c8ef150810010551x174fad1mc788e2f6e97b21c5@mail.gmail.com>
References: <48315FF6.9070909@bluegiga.com>
	<d6c8ef150810010551x174fad1mc788e2f6e97b21c5@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1165
Lines: 31

> I have AT91SAM9260-based board, kernel is 2.6.26.3.

I'm using my RTC-patch with the same CPU. Custom AT91SAM9260 board,
external RTC because of AT's errata...

> M41T94 is connected on SPI channel 1, chip select 0. I've applied
> Kim's patch and added SPI device in board-sam9260ek.c

> 	{	/* External RTC */
> 		.modalias	= "rtc-m41t94",
> 		.chip_select	= 0,
> 		.max_speed_hz	= 2 * 1000 * 1000,
> 		.bus_num	= 1,
> 	},

I'm using it with ".max_speed_hz = 1 * 1000 * 1000," instead of 2 MHz.
Can you try with slower speed? My patch (rev 3) and this small
ek_spi_devices[] modification should be enough.

I have it on bus = 0, chip_select = 1, so I've also removed dataflash
parts from ek_spi_devices[] (we're using NOR flash). But for you this
is not needed.

I also have a patch to add support for M41T94's watchdog timer. It's
not clean enough to be submitted upstreams yet. If you need it I can
email it to you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/