Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755917AbYJBXhY (ORCPT ); Thu, 2 Oct 2008 19:37:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753487AbYJBXhB (ORCPT ); Thu, 2 Oct 2008 19:37:01 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.123]:54445 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753019AbYJBXhA (ORCPT ); Thu, 2 Oct 2008 19:37:00 -0400 Date: Thu, 2 Oct 2008 19:36:57 -0400 (EDT) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Ingo Molnar cc: Linus Torvalds , Peter Zijlstra , Jonathan Corbet , Mathieu Desnoyers , LKML , Thomas Gleixner , Andrew Morton , prasad@linux.vnet.ibm.com, "Frank Ch. Eigler" , David Wilder , hch@lst.de, Martin Bligh , Christoph Hellwig , Masami Hiramatsu , Steven Rostedt , Arnaldo Carvalho de Melo Subject: Re: [PATCH] ring_buffer: map to cpu not page In-Reply-To: Message-ID: References: <20080930092001.69849210@bike.lwn.net> <1222790072.24384.21.camel@twins> <20081002085030.GF26084@elte.hu> <20081002085145.GA3202@elte.hu> <20081002090517.GA8708@elte.hu> <20081002093835.GA17699@elte.hu> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 837 Lines: 27 On Thu, 2 Oct 2008, Steven Rostedt wrote: > > My original patch had a compile bug when NUMA was configured. I > referenced cpu when it should have been cpu_buffer->cpu. > > Ingo quickly fixed this bug by replacing cpu with 'i' because that > was the loop counter. Unfortunately, the 'i' was the counter of > pages, not CPUs. This caused a crash when the number of pages allocated > for the buffers exceeded the number of pages, which would usually That should have been: "when the number of pages allocated for the buffers exceeded the number of cpus". > be the case. > -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/