Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754799AbYJCFVF (ORCPT ); Fri, 3 Oct 2008 01:21:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751663AbYJCFUy (ORCPT ); Fri, 3 Oct 2008 01:20:54 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.123]:49004 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751402AbYJCFUy (ORCPT ); Fri, 3 Oct 2008 01:20:54 -0400 Date: Fri, 3 Oct 2008 01:20:51 -0400 (EDT) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Mathieu Desnoyers cc: Ingo Molnar , Linus Torvalds , Peter Zijlstra , Jonathan Corbet , LKML , Thomas Gleixner , Andrew Morton , prasad@linux.vnet.ibm.com, "Frank Ch. Eigler" , David Wilder , hch@lst.de, Martin Bligh , Christoph Hellwig , Masami Hiramatsu , Steven Rostedt , Arnaldo Carvalho de Melo Subject: Re: [PATCH] x86 Topology cpu_to_node parameter check In-Reply-To: <20081003045607.GA5940@Krystal> Message-ID: References: <1222790072.24384.21.camel@twins> <20081002085030.GF26084@elte.hu> <20081002085145.GA3202@elte.hu> <20081002090517.GA8708@elte.hu> <20081002093835.GA17699@elte.hu> <20081003045607.GA5940@Krystal> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1394 Lines: 50 On Fri, 3 Oct 2008, Mathieu Desnoyers wrote: > --- > include/asm-x86/topology.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > Index: linux-2.6-lttng/include/asm-x86/topology.h > =================================================================== > --- linux-2.6-lttng.orig/include/asm-x86/topology.h 2008-10-03 00:37:05.000000000 -0400 > +++ linux-2.6-lttng/include/asm-x86/topology.h 2008-10-03 00:45:52.000000000 -0400 > @@ -182,9 +182,9 @@ extern int __node_distance(int, int); > > #else /* !CONFIG_NUMA */ > > -#define numa_node_id() 0 > -#define cpu_to_node(cpu) 0 > -#define early_cpu_to_node(cpu) 0 > +#define numa_node_id() 0 > +#define cpu_to_node(cpu) ((void)(cpu),0) > +#define early_cpu_to_node(cpu) cpu_to_node(cpu) Actually the proper way would be to have: static inline int cpu_to_node(int cpu) { return 0; } static inline int early_cpu_to_node(int cpu) { return 0; } This way you also get typechecks. -- Steve > > static inline const cpumask_t *_node_to_cpumask_ptr(int node) > { > -- > Mathieu Desnoyers > OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/