Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754585AbYJCH37 (ORCPT ); Fri, 3 Oct 2008 03:29:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753366AbYJCH3u (ORCPT ); Fri, 3 Oct 2008 03:29:50 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:48625 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752703AbYJCH3t (ORCPT ); Fri, 3 Oct 2008 03:29:49 -0400 Date: Fri, 3 Oct 2008 09:27:22 +0200 From: Ingo Molnar To: Steven Rostedt Cc: Linus Torvalds , Peter Zijlstra , Jonathan Corbet , Mathieu Desnoyers , LKML , Thomas Gleixner , Andrew Morton , prasad@linux.vnet.ibm.com, "Frank Ch. Eigler" , David Wilder , hch@lst.de, Martin Bligh , Christoph Hellwig , Masami Hiramatsu , Steven Rostedt , Arnaldo Carvalho de Melo Subject: Re: [PATCH] ring_buffer: map to cpu not page Message-ID: <20081003072722.GB4950@elte.hu> References: <1222790072.24384.21.camel@twins> <20081002085030.GF26084@elte.hu> <20081002085145.GA3202@elte.hu> <20081002090517.GA8708@elte.hu> <20081002093835.GA17699@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1196 Lines: 30 * Steven Rostedt wrote: > My original patch had a compile bug when NUMA was configured. I > referenced cpu when it should have been cpu_buffer->cpu. > > Ingo quickly fixed this bug by replacing cpu with 'i' because that was > the loop counter. Unfortunately, the 'i' was the counter of pages, not > CPUs. This caused a crash when the number of pages allocated for the > buffers exceeded the number of pages, which would usually be the case. > > Signed-off-by: Steven Rostedt > for (i = 0; i < nr_pages; i++) { > page = kzalloc_node(ALIGN(sizeof(*page), cache_line_size()), > - GFP_KERNEL, cpu_to_node(i)); > + GFP_KERNEL, cpu_to_node(cpu_buffer->cpu)); oh, stupid typo of the year :-) applied to tip/tracing/ring-buffer, thanks for tracking it down! I've reactivated the topic branch for tip/master and i'm running a few tests before pushing it out for wider testing. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/