Date: Fri, 3 Oct 2008 09:44:13 +0200
From: Ingo Molnar <mingo@elte.hu>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: =?iso-8859-1?B?IkouQS4gTWFnYWxs824i?= <jamagallon@ono.com>,
       Linux-Kernel <linux-kernel@vger.kernel.org>,
       Yinghai Lu <yinghai@kernel.org>, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 2/2] x86: mtrr_cleanup try gran_size to less than 1M
Message-ID: <20081003074413.GF4950@elte.hu>
References: <1222739652-17169-1-git-send-email-yhlu.kernel@gmail.com> <1222739652-17169-2-git-send-email-yhlu.kernel@gmail.com> <20081003003237.04469201@werewolf.home> <20081003073727.GC4950@elte.hu> <48E5CC5F.4020300@zytor.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <48E5CC5F.4020300@zytor.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 985
Lines: 31


* H. Peter Anvin <hpa@zytor.com> wrote:

> Ingo Molnar wrote:
>>
>>> +++ arch/x86/kernel/cpu/mtrr/if.c     2008-10-03 00:22:34.000000000 +0200
>>> @@ -16,7 +16,7 @@
>>>  static const char *const mtrr_strings[MTRR_NUM_TYPES] =
>>>  {
>>>      "uncachable",               /* 0 */
>>> -    "write-combining",          /* 1 */
>>> +    "write-combine",            /* 1 */
>>
>> hm, maybe this bit could confuse versions of Xorg that modifies  
>> /proc/mtrr - i.e. this could be part of the ABI towards user-space.  
>> We'll see.
>>
>
> By the way, this is just plain wrong; the cachability name is "Write 
> Combining (WC)" not "write-combine".

and "uncachable" should be "uncacheable" i guess.

anyway, agreed, lets not touch this.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/