Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754541AbYJCP4e (ORCPT ); Fri, 3 Oct 2008 11:56:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753789AbYJCP4J (ORCPT ); Fri, 3 Oct 2008 11:56:09 -0400 Received: from tomts36-srv.bellnexxia.net ([209.226.175.93]:53945 "EHLO tomts36-srv.bellnexxia.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753635AbYJCP4I (ORCPT ); Fri, 3 Oct 2008 11:56:08 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AqAEAPvY5UhMQWq+/2dsb2JhbACBcbpMgWg Date: Fri, 3 Oct 2008 11:56:05 -0400 From: Mathieu Desnoyers To: Steven Rostedt Cc: Ingo Molnar , Linus Torvalds , Peter Zijlstra , Jonathan Corbet , LKML , Thomas Gleixner , Andrew Morton , prasad@linux.vnet.ibm.com, "Frank Ch. Eigler" , David Wilder , hch@lst.de, Martin Bligh , Christoph Hellwig , Masami Hiramatsu , Steven Rostedt , Arnaldo Carvalho de Melo Subject: Re: [PATCH] x86 Topology cpu_to_node parameter check Message-ID: <20081003155605.GC1607@Krystal> References: <20081002085030.GF26084@elte.hu> <20081002085145.GA3202@elte.hu> <20081002090517.GA8708@elte.hu> <20081002093835.GA17699@elte.hu> <20081003045607.GA5940@Krystal> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: X-Editor: vi X-Info: http://krystal.dyndns.org:8080 X-Operating-System: Linux/2.6.21.3-grsec (i686) X-Uptime: 11:55:24 up 120 days, 20:35, 8 users, load average: 0.20, 0.29, 0.67 User-Agent: Mutt/1.5.16 (2007-06-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1774 Lines: 62 * Steven Rostedt (rostedt@goodmis.org) wrote: > > On Fri, 3 Oct 2008, Mathieu Desnoyers wrote: > > > --- > > include/asm-x86/topology.h | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > Index: linux-2.6-lttng/include/asm-x86/topology.h > > =================================================================== > > --- linux-2.6-lttng.orig/include/asm-x86/topology.h 2008-10-03 00:37:05.000000000 -0400 > > +++ linux-2.6-lttng/include/asm-x86/topology.h 2008-10-03 00:45:52.000000000 -0400 > > @@ -182,9 +182,9 @@ extern int __node_distance(int, int); > > > > #else /* !CONFIG_NUMA */ > > > > -#define numa_node_id() 0 > > -#define cpu_to_node(cpu) 0 > > -#define early_cpu_to_node(cpu) 0 > > +#define numa_node_id() 0 > > +#define cpu_to_node(cpu) ((void)(cpu),0) > > +#define early_cpu_to_node(cpu) cpu_to_node(cpu) > > Actually the proper way would be to have: > > static inline int cpu_to_node(int cpu) > { > return 0; > } > > static inline int early_cpu_to_node(int cpu) > { > return 0; > } > > This way you also get typechecks. > That's how I did it first, but then I looked at asm-generic/topology.h and have seen it uses #defines. Should we change them too ? Mathieu > -- Steve > > > > > static inline const cpumask_t *_node_to_cpumask_ptr(int node) > > { > > -- > > Mathieu Desnoyers > > OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 > > > -- Mathieu Desnoyers OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/