Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754392AbYJCX2U (ORCPT ); Fri, 3 Oct 2008 19:28:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753251AbYJCX2F (ORCPT ); Fri, 3 Oct 2008 19:28:05 -0400 Received: from rv-out-0506.google.com ([209.85.198.228]:4801 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752952AbYJCX2C (ORCPT ); Fri, 3 Oct 2008 19:28:02 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=YFDAQUgIE/Rs/MSWAtLdBVrqj+Ze5m9TXLynFV31/w/S5ed/sAhdMcWZa5gDuHec1x h3V2ijI4jDxrT/ZKPFXKW0oXYYBilaJIIuiFZObEDOcoG7dTOW583d1QI0pfpEuVYIsu pF+UZ/l9LMrETQ+nk5lyGs8vY8J02uahaqb5c= Message-ID: <4807377b0810031628x43f79eferdbb9c9c264a5816e@mail.gmail.com> Date: Fri, 3 Oct 2008 16:28:01 -0700 From: "Jesse Brandeburg" To: "Jiri Kosina" Subject: Re: [RFC PATCH 02/12] On Tue, 23 Sep 2008, David Miller wrote: Cc: "Jesse Barnes" , "David Miller" , jesse.brandeburg@intel.com, linux-kernel@vger.kernel.org, linux-netdev@vger.kernel.org, kkeil@suse.de, agospoda@redhat.com, arjan@linux.intel.com, david.graham@intel.com, bruce.w.allan@intel.com, john.ronciak@intel.com, "Thomas Gleixner" , chris.jones@canonical.com, tim.gardner@intel.com, airlied@gmail.com, "Olaf Kirch" , "Linus Torvalds" In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080930030825.22950.18891.stgit@jbrandeb-bw.jf.intel.com> <200810021523.45884.jbarnes@virtuousgeek.org> <20081003.134634.240211201.davem@davemloft.net> <200810031429.22598.jbarnes@virtuousgeek.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1532 Lines: 37 On Fri, Oct 3, 2008 at 2:45 PM, Jiri Kosina wrote: > Karsten has been testing kernel with these three patches from the series > applied: > > e1000e: reset swflag after resetting hardware > e1000e: fix lockdep issues > e1000e: debug contention on NVM SWFLAG > > This was done on a hardware which previously triggered the bug in just a > few test iterations in quite a reliable way. Now, with these patches > applied, the EEPROM corruption didn't happen after several tens of > iterations. > > Please note, that the patch that disables the writes to EEPROM on hardware > level was *not* involved in this testing. > > Therefore it currently seems that these three patches really address the > race condition issue that was present in the e1000e driver. Our experience is different. We are also testing with the "protection patch" reverted. We see that the problem specifically comes and goes when removing/adding the use of set_memory_ro/set_memory_rw to the driver. I'm working to catch the bad element in the act with a hardware breakpoint or an ITP (we're trying both) > It is still not clear why the bug started triggering all of a sudden for > so many people though. we plan to keep on working on this until we understand what is going on. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/