Date: Sun, 5 Oct 2008 22:36:58 -0700
From: Greg KH <greg@kroah.com>
To: Alan Cox <alan@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 38/76] tty: usb-serial krefs
Message-ID: <20081006053658.GA26817@kroah.com>
References: <20081005160231.1997.10462.stgit@localhost.localdomain> <20081005161056.1997.12765.stgit@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20081005161056.1997.12765.stgit@localhost.localdomain>
User-Agent: Mutt/1.5.16 (2007-06-09)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 760
Lines: 18

On Sun, Oct 05, 2008 at 05:11:38PM +0100, Alan Cox wrote:
> Use kref in the USB serial drivers so that we don't free tty structures
> from under the URB receive handlers as has historically been the case if
> you were unlucky. This also gives us a framework for general tty drivers to
> use tty_port objects and refcount.

Should we be calling kref_get() and kref_put() in interrupt context?
Could we just get the reference in open and then put in close when we
are done with it for each driver?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/