Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753517AbYJGJn0 (ORCPT ); Tue, 7 Oct 2008 05:43:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752474AbYJGJnS (ORCPT ); Tue, 7 Oct 2008 05:43:18 -0400 Received: from [210.82.31.146] ([210.82.31.146]:39933 "EHLO mx.linux.net.cn" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751027AbYJGJnR (ORCPT ); Tue, 7 Oct 2008 05:43:17 -0400 X-Greylist: delayed 1473 seconds by postgrey-1.27 at vger.kernel.org; Tue, 07 Oct 2008 05:43:17 EDT Message-ID: <48EB296E.5050808@linux.net.cn> Date: Tue, 07 Oct 2008 17:18:38 +0800 From: Wang Jian User-Agent: Thunderbird 2.0.0.17 (Windows/20080914) MIME-Version: 1.0 To: Tejun Heo CC: avorontsov@ru.mvista.com, Matt Sealey , Jeff Garzik , linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Li Yang Subject: Re: [PATCH] pata_of_platform: fix no irq handling References: <20081006172653.GA26427@oksana.dev.rtsoft.ru> <48EA77EF.6080502@genesi-usa.com> <20081006213209.GA13072@oksana.dev.rtsoft.ru> <48EABBD3.1010401@kernel.org> In-Reply-To: <48EABBD3.1010401@kernel.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1103 Lines: 26 Tejun Heo wrote: > Anton Vorontsov wrote: >> On Mon, Oct 06, 2008 at 03:41:19PM -0500, Matt Sealey wrote: >>> There is a simple problem with the patch which is that an "IRQ 0" can and does >>> actually exist on a bunch of platforms, at least to the best of my knowledge. >>> >>> Checking for -1 (which means for definite, no irq at all, because it is >>> totally unambiguous, as a -1 IRQ numbering is "impossible") is more correct. >> This was discussed years ago. >> >> http://lkml.org/lkml/2005/11/22/159 >> http://lkml.org/lkml/2005/11/22/227 >> > > Would this break any existing platforms? If so, can those be fixed > together or does it become a much bigger problem that way? > Pata_of_platform stacks upon pata_platform. This patch fixes problem concerning definition of "no irq" without touch any other place. So far I can't see any new problem. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/