Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753716AbYJGLIT (ORCPT ); Tue, 7 Oct 2008 07:08:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752860AbYJGLIG (ORCPT ); Tue, 7 Oct 2008 07:08:06 -0400 Received: from one.firstfloor.org ([213.235.205.2]:58121 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752653AbYJGLIE (ORCPT ); Tue, 7 Oct 2008 07:08:04 -0400 Date: Tue, 7 Oct 2008 13:14:10 +0200 From: Andi Kleen To: =?iso-8859-1?Q?Am=E9rico?= Wang Cc: Andi Kleen , linux-kernel@vger.kernel.org, akpm@osdl.org Subject: Re: [PATCH] Add kerneldoc documentation for new printk format extensions Message-ID: <20081007111410.GF20740@one.firstfloor.org> References: <20081007101532.GA25565@basil.nowhere.org> <20081007103305.GH2886@hack.voiplan.pt> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20081007103305.GH2886@hack.voiplan.pt> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1756 Lines: 51 On Tue, Oct 07, 2008 at 11:33:05AM +0100, Am?rico Wang wrote: > On Tue, Oct 07, 2008 at 12:15:32PM +0200, Andi Kleen wrote: > >Add documentation in kerneldoc for new printk format extensions > > > >This patch documents the new %pS/%pF options in printk in kernel doc. > > > >Hope I didn't miss any other extension. > > > >Signed-off-by: Andi Kleen > > > >Index: linux-2.6.27-rc6-misc/kernel/printk.c > >=================================================================== > >--- linux-2.6.27-rc6-misc.orig/kernel/printk.c > >+++ linux-2.6.27-rc6-misc/kernel/printk.c > >@@ -593,6 +593,8 @@ static int have_callable_console(void) > > * > > * See also: > > * printf(3) > >+ * > >+ * See the vsnprintf() documentation for format string extensions over C99. > > */ > > > > asmlinkage int printk(const char *fmt, ...) > >Index: linux-2.6.27-rc6-misc/lib/vsprintf.c > >=================================================================== > >--- linux-2.6.27-rc6-misc.orig/lib/vsprintf.c > >+++ linux-2.6.27-rc6-misc/lib/vsprintf.c > >@@ -565,6 +565,10 @@ static char *pointer(const char *fmt, ch > > * @fmt: The format string to use > > * @args: Arguments for the format string > > * > >+ * This function follows C99 vsnprintf, but has some extensions: > >+ * %pS output the name of a text symbol > >+ * %pF output the name of a function pointer > > s/output/outputs/ ? :) It's not complete sentences but a list of options, so no. bla do this blub do that -Andi -- ak@linux.intel.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/