Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754383AbYJGLTo (ORCPT ); Tue, 7 Oct 2008 07:19:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752641AbYJGLTf (ORCPT ); Tue, 7 Oct 2008 07:19:35 -0400 Received: from hs-out-0708.google.com ([64.233.178.247]:10198 "EHLO hs-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751081AbYJGLTf (ORCPT ); Tue, 7 Oct 2008 07:19:35 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=aQ5nY8Y2Xl/9UBfyCSciS9F7pxDJu+maDk8BBHyHP3oZQR2yAiXRT+dDLVqL2POZvz IKUMx/0DKtA7nx84BretN+R3WQMnKEd8M7lYwXCJ9YhjNw9mULSYSNaYIZp2ripn1sLs sfW34SMxnWede0bGjN+yDTLUOxO4HobD+9kB0= Date: Tue, 7 Oct 2008 07:19:28 -0400 From: Dmitry Torokhov To: Ingo Molnar Cc: Andreas Herrmann , "Maciej W. Rozycki" , Andi Kleen , Linus Torvalds , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Andrew Morton , Len Brown , Jason Vas Dias Subject: Re: [PATCH] x86: SB450: skip IRQ0 override if it is not routed to INT2 of IOAPIC Message-ID: <20081007111927.GA2795@amd.corenet.prv> References: <200810061159.30103.rjw@sisk.pl> <20081006150055.GA16930@elte.hu> <87tzbpmocm.fsf@basil.nowhere.org> <20081006221122.GC22097@alberich.amd.com> <20081007034132.GA3025@elte.hu> <20081007035126.GA2929@amd.corenet.prv> <20081007045757.GB6355@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081007045757.GB6355@elte.hu> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2078 Lines: 57 On Tue, Oct 07, 2008 at 06:57:57AM +0200, Ingo Molnar wrote: > > * Dmitry Torokhov wrote: > > > On Tue, Oct 07, 2008 at 05:41:32AM +0200, Ingo Molnar wrote: > > > > > > * Andreas Herrmann wrote: > > > > > > > So, let's work around BIOS bugs in Linux then ... > > > > > > > > Following patch is almost untested -- especially I didn't get my hands > > > > on one of the HP Laptops with broken DSDT. > > > [...] > > > > On some HP nx6... laptops (e.g. nx6325) BIOS reports an IRQ0 override > > > > but the SB450 chipset is configured such that timer interrupts goe to > > > > INT0 of IOAPIC. > > > > > > > > Check IRQ0 routing and if it is routed to INT0 of IOAPIC skip the > > > > timer override. > > > > > > > > Signed-off-by: Andreas Herrmann > > > > > > > > --- > > > > arch/x86/kernel/early-quirks.c | 48 ++++++++++++++++++++++++++++++++++++++++ > > > > 1 files changed, 48 insertions(+), 0 deletions(-) > > > > > > very nice, thanks Andreas! Applied to tip/x86/quirks. This PCI ID based > > > quirk should be more complete than DMI matches. > > > > > > > You may add 'Tested by: Dmitry Torokhov on nx6115' > > It works fine here with Andreas patch applied and with Rafael's patch > > dropped. > > > > Thanks Andreas! > > ok, added your Tested-by to the changelog, thanks. > > I also applied the patch below to deprioritize the DMI quirks for this > problem (without actually removing them, yet). Could you please check > whether latest tip/master: > > http://people.redhat.com/mingo/tip.git/README > > boots fine out of box and that the WARN() does not trigger? > While I did not test tip/master I applied this patch on top of Andreas's patch and the warning, as expected, did not trigger. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/