Date: Wed, 8 Oct 2008 15:16:56 +0200
From: Christoph Hellwig <hch@lst.de>
To: Tiger Yang <tiger.yang@oracle.com>
Cc: Mark Fasheh <mfasheh@suse.com>, Christoph Hellwig <hch@lst.de>,
       linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
       ocfs2-devel@oss.oracle.com
Subject: Re: [Ocfs2-devel] [PATCH 13/39] ocfs2: Add extended attribute support
Message-ID: <20081008131656.GD25392@lst.de>
References: <1222293680-15451-1-git-send-email-mfasheh@suse.com> <1222293680-15451-14-git-send-email-mfasheh@suse.com> <20081002081644.GB24717@lst.de> <20081007220811.GG26373@wotan.suse.de> <48EC1359.6040109@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <48EC1359.6040109@oracle.com>
User-Agent: Mutt/1.3.28i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1285
Lines: 31

On Wed, Oct 08, 2008 at 09:56:41AM +0800, Tiger Yang wrote:
> Mark Fasheh wrote:
> >>>+static inline struct xattr_handler *ocfs2_xattr_handler(int name_index)
> >>>+{
> >>>+	struct xattr_handler *handler = NULL;
> >>>+
> >>>+	if (name_index > 0 && name_index < OCFS2_XATTR_MAX)
> >>>+		handler = ocfs2_xattr_handler_map[name_index];
> >>>+
> >>>+	return handler;
> >>>+}
> >>You seem to need the handler mostly for getting back to the prefix
> >>from the handler.  This is a pretty clear indicator that you don't
> >>want to use the xattr_handler splitting but deal with the whole
> >>attr name.  Take a look at the btrfs code after my recent xattr changes
> >>on how to handle this more nicely.
> >
> >Tao, Can you look into this?
> 
> I have looked the patch for btrfs about this. We are different.
> Btrfs store the whole xattr name including the prefix "user." 
> "trusted.", we store index number instead of it.

In which case you shouldn't need to look the handler up anyway.  I'll
re-review the code once you post the next version.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/