Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755085AbYJHNXE (ORCPT ); Wed, 8 Oct 2008 09:23:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752228AbYJHNWw (ORCPT ); Wed, 8 Oct 2008 09:22:52 -0400 Received: from verein.lst.de ([213.95.11.210]:43713 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751694AbYJHNWv (ORCPT ); Wed, 8 Oct 2008 09:22:51 -0400 Date: Wed, 8 Oct 2008 15:22:32 +0200 From: Christoph Hellwig To: Mark Fasheh Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com, Tao Ma Subject: Re: [Ocfs2-devel] [PATCH 13/39] ocfs2: Add extended attribute support Message-ID: <20081008132232.GG25392@lst.de> References: <1222293680-15451-1-git-send-email-mfasheh@suse.com> <1222293680-15451-14-git-send-email-mfasheh@suse.com> <20081002081644.GB24717@lst.de> <20081007220811.GG26373@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081007220811.GG26373@wotan.suse.de> User-Agent: Mutt/1.3.28i X-Spam-Score: 0 () Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1225 Lines: 27 On Tue, Oct 07, 2008 at 03:08:11PM -0700, Mark Fasheh wrote: > On Thu, Oct 02, 2008 at 10:16:44AM +0200, Christoph Hellwig wrote: > > On Wed, Sep 24, 2008 at 03:00:54PM -0700, Mark Fasheh wrote: > > > xattr.o \ > > > + xattr_user.o \ > > > + xattr_trusted.o > > > > Please don't split this up, it's always been a really stupid idea in > > extN. The only difference between secure, trusted and user attrs is > > that they go into a different namespace bit (and have different > > permission checking, but that's handled in the VFS). I have some > > upcoming patches to store a fs private flag in struct xattr_handler > > so that even those flags wrappers can go away, and each of the > > namespaces will just be five lines of code for the xattr_handler > > declaration. > > Ok. The following patch (in ocfs2.git now) removes those two files, and puts > the code for user and trusted xattrs at the bottom of xattr.c. Is that > mainly what you were getting at here? Yeah. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/