Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757007AbYJHW2y (ORCPT ); Wed, 8 Oct 2008 18:28:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754876AbYJHW2q (ORCPT ); Wed, 8 Oct 2008 18:28:46 -0400 Received: from mx2.redhat.com ([66.187.237.31]:58013 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754144AbYJHW2q (ORCPT ); Wed, 8 Oct 2008 18:28:46 -0400 Date: Wed, 8 Oct 2008 18:28:15 -0400 From: Dave Jones To: Anton Vorontsov Cc: Linux Kernel Subject: fsl_upm compile failure. Message-ID: <20081008222815.GA20542@redhat.com> Mail-Followup-To: Dave Jones , Anton Vorontsov , Linux Kernel MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1143 Lines: 36 Hi Anton, I tried reenabling CONFIG_MTD_NAND_FSL_UPM in the Fedora kernel today (currently on 2.6.27-rc9-git1), and got the error below. ERROR: "fsl_lbc_lock" [drivers/mtd/nand/fsl_upm.ko] undefined! It seems that this isn't exported to modules. diff below fixes this. (Not tested yet, the Fedora ppc builders are a little slow). Dave --- CONFIG_MTD_NAND_FSL_UPM can be built modular, but needs to use fsl_lbc_lock, which isn't currently exported. Signed-off-by: Dave Jones diff --git a/arch/powerpc/sysdev/fsl_lbc.c b/arch/powerpc/sysdev/fsl_lbc.c index 422c8fa..1c6c522 100644 --- a/arch/powerpc/sysdev/fsl_lbc.c +++ b/arch/powerpc/sysdev/fsl_lbc.c @@ -16,6 +16,7 @@ #include spinlock_t fsl_lbc_lock = __SPIN_LOCK_UNLOCKED(fsl_lbc_lock); +EXPORT_SYMBOL(fsl_lbc_lock); struct fsl_lbc_regs __iomem *fsl_lbc_regs; EXPORT_SYMBOL(fsl_lbc_regs); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/