Date: Wed, 08 Oct 2008 17:42:02 -0700 (PDT)
Message-Id: <20081008.174202.160320028.davem@davemloft.net>
To: divy@chelsio.com
Cc: jeff@garzik.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
       swise@opengridcomputing.com
Subject: Re: [PATCH 2/8 2.6.28] cxgb3 - Allocate multiqueues at init time
From: David Miller <davem@davemloft.net>
In-Reply-To: <20081009003402.13315.18192.stgit@speedy5>
References: <20081009003402.13315.18192.stgit@speedy5>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 879
Lines: 22

From: Divy Le Ray <divy@chelsio.com>
Date: Wed, 08 Oct 2008 17:34:02 -0700

> Allocate a queue set per core, up to the maximum of available qsets.
> Share the queue sets on multi port adapters.
> Rename MSI-X interrupt vectors ethX-N, N being the queue set number.
> 
> Signed-off-by: Divy Le Ray <divy@chelsio.com>

Applied, but...

This "num processors" logic and policy belongs in some generic place.
Perhaps "num_possible_cpus()" is more appropriate, who knows right?

Otherwise every stinking driver is going to implement this in
their own way and use their own policy, and from a user experience
perspective that totally sucks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/