Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757932AbYJIJSe (ORCPT ); Thu, 9 Oct 2008 05:18:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753824AbYJIJSZ (ORCPT ); Thu, 9 Oct 2008 05:18:25 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:34231 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753468AbYJIJSY (ORCPT ); Thu, 9 Oct 2008 05:18:24 -0400 Date: Thu, 9 Oct 2008 10:18:22 +0100 From: Alan Cox To: chri Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH] max3100 driver Message-ID: <20081009101822.54acd701@lxorguk.ukuu.org.uk> In-Reply-To: References: <1221895208650-git-send-email-chripell@gmail.com> <20080920151149.21dbad1d@lxorguk.ukuu.org.uk> X-Mailer: Claws Mail 3.5.0 (GTK+ 2.12.12; x86_64-redhat-linux-gnu) Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a Lloegr o'r rhif cofrestru 3798903 Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 670 Lines: 19 > > If there has been a hangup the port.tty will be NULL... > > > > I check against NULL. But let me ask again: the other drivers (for > example SA1100) don't do it. How they avoid the nasty NULL pointer > dereference? Some drives keep the tty pointer and deliver data to closed ttys wrongly, others do careful locking, others are just broken. > Sorry again for not having replied before resending the patch. No problem -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/