Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757480AbYJIMbd (ORCPT ); Thu, 9 Oct 2008 08:31:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758579AbYJIMbW (ORCPT ); Thu, 9 Oct 2008 08:31:22 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:47999 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756895AbYJIMbV (ORCPT ); Thu, 9 Oct 2008 08:31:21 -0400 Date: Thu, 9 Oct 2008 14:31:13 +0200 From: Ingo Molnar To: Harvey Harrison Cc: Steven Rostedt , LKML , Joe Perches Subject: Re: [patch] clean hex output of ftrace Message-ID: <20081009123113.GB2952@elte.hu> References: <1223513095.8195.113.camel@brick> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1223513095.8195.113.camel@brick> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00,DNS_FROM_SECURITYSAGE autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] 0.0 DNS_FROM_SECURITYSAGE RBL: Envelope sender in blackholes.securitysage.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1152 Lines: 36 * Harvey Harrison wrote: > On Wed, 2008-10-08 at 17:16 -0700, Joe Perches wrote: > > On Wed, 8 Oct 2008, Harvey Harrison wrote: > > > From: Harvey Harrison > > > Subject: [PATCH] ftrace: Fix inversion of hex output and use common routines > > > > You're quick... > > > > > BUG_ON(len >= HEX_CHARS); > > > > I think the BUG_ON is senseless. > > > > Agreed, it probably meant to say BUG_ON(len * 2 > HEX_CHARS -1) > > But as this is only called from within a helper macro, it could be > changed to a build-time check instead of a runtime: > > From: Harvey Harrison > Subject: [PATCH] trace: add build-time check to avoid overrunning hex buffer applied to tip/tracing/core: bb86ba7: trace: add build-time check to avoid overrunning hex buffer 32ce86f: ftrace: fix hex output mode of ftrace thanks guys! Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/