Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758886AbYJIQ7M (ORCPT ); Thu, 9 Oct 2008 12:59:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753383AbYJIQ6y (ORCPT ); Thu, 9 Oct 2008 12:58:54 -0400 Received: from waste.org ([66.93.16.53]:57332 "EHLO waste.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753080AbYJIQ6w (ORCPT ); Thu, 9 Oct 2008 12:58:52 -0400 Subject: [PATCH] x86: trim ACPI sleep stack buffer From: Matt Mackall To: Pavel Machek Cc: Ingo Molnar , Linux Kernel Mailing List , linux-acpi@vger.kernel.org In-Reply-To: <20081009085649.GC29957@atrey.karlin.mff.cuni.cz> References: <1222819957.13453.15.camel@calx> <20081009085649.GC29957@atrey.karlin.mff.cuni.cz> Content-Type: text/plain Date: Thu, 09 Oct 2008 11:56:21 -0500 Message-Id: <1223571381.17706.94.camel@calx> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1525 Lines: 52 On Thu, 2008-10-09 at 10:56 +0200, Pavel Machek wrote: > > We've got: > > > > #if defined(CONFIG_SMP) && defined(CONFIG_64BIT) > > static char temp_stack[10240]; > > #endif > > > > and: > > > > #ifdef CONFIG_SMP > > stack_start.sp = temp_stack + 4096; > > #endif > > > > ..which suggests we use at most 4k of the stack? > > I guess someone (probably me) was "playing it safe" -- not exactly > remembering if stack grows down or up. I guess it should be safe to > change it... will do that. > Pavel I've already got a patch, I was just wondering if there was some obscure architectural reason for it that I wasn't aware of. x86: trim ACPI sleep stack buffer x86_64 SMP suspend to RAM uses a 10k temporary stack for saving the kernel state, but only 4k of it is used. Shrink it to 4k. Signed-off-by: Matt Mackall diff -r 73d55a1b6c10 arch/x86/kernel/acpi/sleep.c --- a/arch/x86/kernel/acpi/sleep.c Wed Oct 08 14:48:45 2008 -0500 +++ b/arch/x86/kernel/acpi/sleep.c Thu Oct 09 11:51:54 2008 -0500 @@ -21,7 +21,7 @@ static unsigned long acpi_realmode; #if defined(CONFIG_SMP) && defined(CONFIG_64BIT) -static char temp_stack[10240]; +static char temp_stack[4096]; #endif /** -- Mathematics is the supreme nostalgia of our time. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/