Date: Fri, 10 Oct 2008 10:54:29 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Anders Kaseorg <andersk@MIT.EDU>
Cc: Steven Rostedt <rostedt@goodmis.org>, linux-kernel@vger.kernel.org,
       "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] ftrace: Make ftrace_test_p6nop disassembler-friendly
Message-ID: <20081010085429.GB319@elte.hu>
References: <alpine.DEB.2.00.0810092209460.21569@vinegar-pot.mit.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.00.0810092209460.21569@vinegar-pot.mit.edu>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 741
Lines: 23


* Anders Kaseorg <andersk@MIT.EDU> wrote:

> Commit 4c3dc21b136f8cb4b72afee16c3ba7e961656c0b in tip introduced the
> 5-byte NOP ftrace_test_p6nop:
>   jmp . + 5
>   .byte 0x00, 0x00, 0x00
> This is not friendly to disassemblers because an odd number of 0x00s
> ends in the middle of an instruction boundary.  This changes the 0x00s
> to 1-byte NOPs (0x90).
> 
> Signed-off-by: Anders Kaseorg <andersk@mit.edu>

applied to tip/tracing/ftrace, good spotting Anders!

Steve, any objections?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/