Date: Fri, 10 Oct 2008 10:19:41 +0100
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Elias Oltmanns <eo@nebensachen.de>
Cc: Alan Cox <alan@redhat.com>, linux-kernel@vger.kernel.org,
       linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: Better timeout recovery
Message-ID: <20081010101941.5822926e@lxorguk.ukuu.org.uk>
In-Reply-To: <87od1set2a.fsf@denkblock.local>
References: <20081009164351.26205.50193.stgit@localhost.localdomain>
	<87od1set2a.fsf@denkblock.local>
Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street,
 Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a
 Lloegr o'r rhif cofrestru 3798903
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 876
Lines: 27

> I'd very much prefer comments to be formatted like this:

Would you... ;)

> > +	/* Can become DEBUG later */
> > +	if (count)
> > +		ata_port_printk(ap, KERN_WARNING,
> > +			"drained %d bytes to clear DRQ.\n", count);
> > +
> > +}
> 
> Presumably, you didn't intentionally leave a blank line before the
> closing brace.

Yes I did, it looked cleaner.

> Sorry if you were aware of all that and just sent the patch as a first
> draft in order to get comments on the actual code.

At the moment the main concern is the code quality - but you are right
I've not run the result through the style checker and probably should do
so.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/