Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761350AbYJJK42 (ORCPT ); Fri, 10 Oct 2008 06:56:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760127AbYJJKwF (ORCPT ); Fri, 10 Oct 2008 06:52:05 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:47625 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1760116AbYJJKwE (ORCPT ); Fri, 10 Oct 2008 06:52:04 -0400 From: Alan Cox Subject: [PATCH 27/27] serial_8250: pci_enable_device fail is not fully handled To: torvalds@osdl.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Date: Fri, 10 Oct 2008 11:52:00 +0100 Message-ID: <20081010105135.31597.44955.stgit@localhost.localdomain> In-Reply-To: <20081010103447.31597.42992.stgit@localhost.localdomain> References: <20081010103447.31597.42992.stgit@localhost.localdomain> User-Agent: StGIT/0.14.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1137 Lines: 32 talking about leaks - I noticed that the 'check return of pci_enable_dev()' in the 8250 pci resume function finally made it in, inspite my objections against it (causing stuff in higher levels to leak). Signed-off-by: Alan Cox --- drivers/serial/8250_pci.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/serial/8250_pci.c b/drivers/serial/8250_pci.c index c2f2393..c014ffb 100644 --- a/drivers/serial/8250_pci.c +++ b/drivers/serial/8250_pci.c @@ -2041,9 +2041,9 @@ static int pciserial_resume_one(struct pci_dev *dev) * The device may have been disabled. Re-enable it. */ err = pci_enable_device(dev); + /* FIXME: We cannot simply error out here */ if (err) - return err; - + printk(KERN_ERR "pciserial: Unable to re-enable ports, trying to continue.\n"); pciserial_resume_ports(priv); } return 0; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/