DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:in-reply-to:user-agent;
        b=TG9fZkECda7idYbwXyyQSiaH6jdjR+Kl2zDjNFbUB/qPTAPCQhSHqwmPZ0WvBtF80i
         JVfnSDTRGfqVQIg/06I+5Ek87FyuaPoixOuFybM+CVusmWRgKHLfleUF4vzaClyqn3i3
         hFaZ71QCyDtI6N2c1+PSBIsRvFq5a5DL9Uj6s=
Date: Fri, 10 Oct 2008 08:54:34 -0400
From: Josh Boyer <jwboyer@gmail.com>
To: Alan Cox <alan@redhat.com>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org,
       linux-serial@vger.kernel.org
Subject: Re: [PATCH 22/27] serial: Make uart_port's ioport "unsigned long".
Message-ID: <20081010125434.GB8590@yoda.jdub.homelinux.org>
References: <20081010103447.31597.42992.stgit@localhost.localdomain> <20081010105052.31597.41476.stgit@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20081010105052.31597.41476.stgit@localhost.localdomain>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 903
Lines: 24

On Fri, Oct 10, 2008 at 11:50:56AM +0100, Alan Cox wrote:
>From: David Miller <davem@davemloft.net>
>
>Otherwise the top 32-bits of the resource value get chopped
>off on 64-bit systems, and the resulting I/O accesses go to
>random places.
>
>Thanks to testing and debugging by Josip Rodin, which helped
>track this down.
>
>Signed-off-by: David S. Miller <davem@davemloft.net>
>Signed-off-by: Alan Cox <alan@redhat.com>

I emailed on an earlier posting of this about using resource_size_t
instead as we have 32-bit CPUs with 64-bit address spaces.  If I'm
totally wrong, that's fine but I'm still wondering if that would be
a better general solution.

josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/