Date: Fri, 10 Oct 2008 16:58:14 +0200
From: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
To: Anders Blomdell <anders.blomdell@control.lth.se>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Make ATNGW100 serial ports configurable
Message-ID: <20081010165814.1c62eabf@hskinnemo-gx745.norway.atmel.com>
In-Reply-To: <48EF6762.2080205@control.lth.se>
References: <48EF6762.2080205@control.lth.se>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1264
Lines: 32

Anders Blomdell <anders.blomdell@control.lth.se> wrote:
> Make configuration of ATNGW100 serial ports selectable in kernel configuration.
> 
> Signed-off-by: Anders Blomdell <anders.blomdell@control.lth.se>

Gak. If we're going down this path, why not add #ifdefs for every other
conceivable hardware mod as well and turn the ATNGW100 board code into
an even worse mess than the ATSTK1000 board code?

The ATNGW100 has one serial port on board, so IMO the standard board
code should only initialize that one port.

However, it might be sensible to add some sort of interface for
expansion board code. For example something like this:

#ifdef CONFIG_ATNGW100_EXPANSION
	atngw100_setup_expansion_board();
#endif

This will allow people with hardware mods to add all the extra devices
they need, including serial ports, by simply adding another file with
expansion board code. People who aren't afraid to solder stuff on their
boards shouldn't be afraid of writing some board code too, right?

What do you think?

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/