Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761975AbYJJQNT (ORCPT ); Fri, 10 Oct 2008 12:13:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758844AbYJJQNJ (ORCPT ); Fri, 10 Oct 2008 12:13:09 -0400 Received: from terminus.zytor.com ([198.137.202.10]:37751 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754872AbYJJQNI (ORCPT ); Fri, 10 Oct 2008 12:13:08 -0400 Message-ID: <48EF7EE7.6040409@zytor.com> Date: Fri, 10 Oct 2008 09:12:23 -0700 From: "H. Peter Anvin" User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: Steven Rostedt CC: Ingo Molnar , Anders Kaseorg , linux-kernel@vger.kernel.org Subject: Re: [PATCH] ftrace: Make ftrace_test_p6nop disassembler-friendly References: <20081010085429.GB319@elte.hu> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1049 Lines: 32 Steven Rostedt wrote: > On Fri, 10 Oct 2008, Ingo Molnar wrote: > >> * Anders Kaseorg wrote: >> >>> Commit 4c3dc21b136f8cb4b72afee16c3ba7e961656c0b in tip introduced the >>> 5-byte NOP ftrace_test_p6nop: >>> jmp . + 5 >>> .byte 0x00, 0x00, 0x00 >>> This is not friendly to disassemblers because an odd number of 0x00s >>> ends in the middle of an instruction boundary. This changes the 0x00s >>> to 1-byte NOPs (0x90). >>> >>> Signed-off-by: Anders Kaseorg >> applied to tip/tracing/ftrace, good spotting Anders! >> >> Steve, any objections? > > Nope, it's fine with me. > > Acked-by: Steven Rostedt > The (semi-)amusing thing is that it should never, ever, get there. 66 66 66 66 90 is used over this, which should always work. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/