Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761284AbYJJQpp (ORCPT ); Fri, 10 Oct 2008 12:45:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758900AbYJJQph (ORCPT ); Fri, 10 Oct 2008 12:45:37 -0400 Received: from mtagate1.de.ibm.com ([195.212.17.161]:56160 "EHLO mtagate1.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758423AbYJJQpg (ORCPT ); Fri, 10 Oct 2008 12:45:36 -0400 Subject: Re: [RFC][PATCH 2/2] first callers of process_deny_checkpoint() From: Greg Kurz To: "Serge E. Hallyn" Cc: Cedric Le Goater , linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org, Ingo Molnar , arnd@arndb.de, Dave Hansen In-Reply-To: <20081010140430.GA14640@us.ibm.com> References: <20081009190405.13A253CB@kernel> <20081009190406.1B257119@kernel> <48EF2BAB.1010009@fr.ibm.com> <20081010140430.GA14640@us.ibm.com> Content-Type: text/plain Date: Fri, 10 Oct 2008 18:45:32 +0200 Message-Id: <1223657132.10017.42.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 (2.22.3.1-1.fc9) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1302 Lines: 33 On Fri, 2008-10-10 at 09:04 -0500, Serge E. Hallyn wrote: > Remember a part of Ingo's motivation is to push c/r developers to > address the lacking features that users use most, earlier. So the > warnings and subsequent email complaints are what we're after. Hence a > single 'checkpointable or not' flag. > > Given the single flag, how do you know at sys_mq_unlink() whether the > process also has an opensocket? > > Rather than make this tracking facility more complicated and intrusive, > if people complain that they couldn't checkpoint bc of a warning about > aio, then we implement aio c/r! We don't just try and reduce the amount > of time that you can't checkpoint bc of lack of aio c/r support :) > > -serge Serge, It's exactly what I meant before, the tracking facility would be awfully complicated. It cannot be done that way. But there's also something awkward with the flag thing : can you provide right now an exhaustive list of all the places where you must raise it ? I'd rather do some heavy checking at checkpoint time. Greg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/