Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757910AbYJKOJT (ORCPT ); Sat, 11 Oct 2008 10:09:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753370AbYJKOJG (ORCPT ); Sat, 11 Oct 2008 10:09:06 -0400 Received: from pasmtpb.tele.dk ([80.160.77.98]:35080 "EHLO pasmtpB.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753149AbYJKOJF (ORCPT ); Sat, 11 Oct 2008 10:09:05 -0400 Date: Sat, 11 Oct 2008 16:08:27 +0200 From: Jens Axboe To: Ingo Molnar Cc: Tejun Heo , Linus Torvalds , linux-kernel@vger.kernel.org, Andrew Morton , Thomas Gleixner , "H. Peter Anvin" , Yinghai Lu Subject: Re: [bug] latest -git boot hang Message-ID: <20081011140826.GS19428@kernel.dk> References: <20081010203043.GA11798@elte.hu> <20081010204015.GA15668@elte.hu> <20081010205642.GA28840@elte.hu> <48EFF84B.5060108@kernel.org> <20081011071939.GA26465@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081011071939.GA26465@elte.hu> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4373 Lines: 101 On Sat, Oct 11 2008, Ingo Molnar wrote: > > * Tejun Heo wrote: > > > > It does sound like perhaps the option should be hidden more, if it's > > > really only reasonably enabled for some very specialized distro > > > debuggers, not normal kernel people. > > > > Yeap, if fedora didn't work, I think it should be hidden. Do we > > already have place to hide things like this? > > in my local testing i'm using simple annotations like the one attached > further below. Any objections against sending my BROKEN_BOOT_ALLOWED kit > upstream, and merge my annotations for various kernel features that > break a generic distro bootup? > > Right now i have about 40 such annotations for -tip testing: > > fs/Kconfig: depends on BROKEN_BOOT_ALLOWED > fs/Kconfig: depends on BROKEN_BOOT_ALLOWED > security/selinux/Kconfig: depends on BROKEN_BOOT_ALLOWED > security/smack/Kconfig: depends on BROKEN_BOOT_ALLOWED > security/Kconfig: depends on BROKEN_BOOT_ALLOWED > drivers/net/appletalk/Kconfig: depends on BROKEN_BOOT_ALLOWED > drivers/net/Kconfig: depends on BROKEN_BOOT_ALLOWED > drivers/media/video/Kconfig: depends on BROKEN_BOOT_ALLOWED > drivers/scsi/Kconfig: depends on BROKEN_BOOT_ALLOWED > drivers/watchdog/Kconfig: depends on BROKEN_BOOT_ALLOWED > drivers/watchdog/Kconfig: depends on BROKEN_BOOT_ALLOWED > drivers/ide/Kconfig: depends on BROKEN_BOOT_ALLOWED > drivers/i2c/busses/Kconfig: depends on BROKEN_BOOT_ALLOWED > drivers/block/Kconfig: depends on BROKEN_BOOT_ALLOWED > drivers/video/Kconfig: depends on BROKEN_BOOT_ALLOWED > drivers/video/Kconfig: depends on BROKEN_BOOT_ALLOWED > drivers/video/Kconfig: depends on BROKEN_BOOT_ALLOWED > drivers/video/Kconfig: depends on BROKEN_BOOT_ALLOWED > drivers/video/Kconfig: depends on BROKEN_BOOT_ALLOWED > drivers/video/Kconfig: depends on BROKEN_BOOT_ALLOWED > drivers/video/Kconfig: depends on BROKEN_BOOT_ALLOWED > drivers/video/console/Kconfig: depends on BROKEN_BOOT_ALLOWED > drivers/video/console/Kconfig: depends on BROKEN_BOOT_ALLOWED > drivers/mtd/Kconfig: depends on BROKEN_BOOT_ALLOWED > drivers/isdn/icn/Kconfig: depends on BROKEN_BOOT_ALLOWED > lib/Kconfig.kgdb: depends on BROKEN_BOOT_ALLOWED > lib/Kconfig.debug: depends on BROKEN_BOOT_ALLOWED > lib/Kconfig.debug: depends on BROKEN_BOOT_ALLOWED > arch/x86/Kconfig.debug: depends on BROKEN_BOOT_ALLOWED > arch/x86/Kconfig: depends on BROKEN_BOOT_ALLOWED > arch/x86/Kconfig: depends on BROKEN_BOOT_ALLOWED > arch/x86/Kconfig: depends on BROKEN_BOOT_ALLOWED > arch/x86/Kconfig: depends on BROKEN_BOOT_ALLOWED > arch/x86/Kconfig: # depends on BROKEN_BOOT_ALLOWED > arch/x86/Kconfig: depends on BROKEN_BOOT_ALLOWED > arch/x86/Kconfig: depends on BROKEN_BOOT_ALLOWED > arch/x86/Kconfig: depends on BROKEN_BOOT_ALLOWED > arch/x86/Kconfig: depends on BROKEN_BOOT_ALLOWED > arch/x86/Kconfig.cpu: depends on BROKEN_BOOT_ALLOWED > > and note the stark contrast to CONFIG_BROKEN - sometimes a given > functionality is really not meant to be enabled on a generic system. > > Ingo > > ----------------> > Subject: qa: no ext devt > From: Ingo Molnar > Date: Fri Oct 10 22:54:57 CEST 2008 > > Signed-off-by: Ingo Molnar > --- > lib/Kconfig.debug | 2 ++ > 1 file changed, 2 insertions(+) > > Index: linux/lib/Kconfig.debug > =================================================================== > --- linux.orig/lib/Kconfig.debug > +++ linux/lib/Kconfig.debug > @@ -670,6 +670,8 @@ config DEBUG_BLOCK_EXT_DEVT > bool "Force extended block device numbers and spread them" > depends on DEBUG_KERNEL > depends on BLOCK > + depends on BROKEN_BOOT_ALLOWED > + select BROKEN_BOOT > default n > help > Conventionally, block device numbers are allocated from What is BROKEN_BOOT_ALLOWED? Honestly, I'd prefer to just put an extra 2-3 line paragraph in the help entry, saying that it's quite possible that current distros wont boot with this testing code enabled. Since it default to 'n', people should read the entry before turning it on anyway. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/