Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762729AbYJKTUJ (ORCPT ); Sat, 11 Oct 2008 15:20:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758706AbYJKTTz (ORCPT ); Sat, 11 Oct 2008 15:19:55 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:42021 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1755144AbYJKTTy (ORCPT ); Sat, 11 Oct 2008 15:19:54 -0400 Date: Sat, 11 Oct 2008 12:19:30 -0700 (PDT) Message-Id: <20081011.121930.193700319.davem@davemloft.net> To: torvalds@linux-foundation.org Cc: akpm@linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [GIT]: Networking for 2.6.28 From: David Miller In-Reply-To: References: <20081010.144921.115563930.davem@davemloft.net> X-Mailer: Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2457 Lines: 73 From: Linus Torvalds Date: Sat, 11 Oct 2008 10:57:29 -0700 (PDT) > > > On Sat, 11 Oct 2008, Linus Torvalds wrote: > > > > On Fri, 10 Oct 2008, David Miller wrote: > > > > > > Here are the queued up networking changes for the 2.6.28 merge window. > > > > This generates _tons_ of new warnings for me: > > And apparently errors for others: > > net/netfilter/ipvs/ip_vs_xmit.c: In function 'ip_vs_tunnel_xmit': > net/netfilter/ipvs/ip_vs_xmit.c:616: error: implicit declaration of function 'ip_select_ident' > > some other config-dependent breakage. So the proper include (of net/ip.h) is there in ip_vs_xmit.c, but this failure can also happen if CONFIG_INET is not enabled. Are you doing that kind of test build? This patch should fix that case, let me know if it works: ipvs: Add proper dependencies on IP_VS, and fix description header line. Linus noted a build failure case: net/netfilter/ipvs/ip_vs_xmit.c: In function 'ip_vs_tunnel_xmit': net/netfilter/ipvs/ip_vs_xmit.c:616: error: implicit declaration of function 'ip_select_ident' The proper include file (net/ip.h) is being included in ip_vs_xmit.c to get that declaration. So the only possible case where this can happen is if CONFIG_INET is not enabled. This seems to be purely a missing dependency in the ipvs/Kconfig file IP_VS entry. Also, while we're here, remove the out of date "EXPERIMENTAL" string in the IP_VS config help header line. IP_VS no longer depends upon CONFIG_EXPERIMENTAL Signed-off-by: David S. Miller --- net/netfilter/ipvs/Kconfig | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/netfilter/ipvs/Kconfig b/net/netfilter/ipvs/Kconfig index de6004d..05048e4 100644 --- a/net/netfilter/ipvs/Kconfig +++ b/net/netfilter/ipvs/Kconfig @@ -2,8 +2,8 @@ # IP Virtual Server configuration # menuconfig IP_VS - tristate "IP virtual server support (EXPERIMENTAL)" - depends on NETFILTER + tristate "IP virtual server support" + depends on NET && INET && NETFILTER ---help--- IP Virtual Server support will let you build a high-performance virtual server based on cluster of two or more real servers. This -- 1.5.6.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/