Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753916AbYJLHMV (ORCPT ); Sun, 12 Oct 2008 03:12:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750966AbYJLHMN (ORCPT ); Sun, 12 Oct 2008 03:12:13 -0400 Received: from colo.lackof.org ([198.49.126.79]:34782 "EHLO colo.lackof.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750899AbYJLHMM (ORCPT ); Sun, 12 Oct 2008 03:12:12 -0400 Date: Sun, 12 Oct 2008 01:11:57 -0600 From: Grant Grundler To: Yinghai Lu Cc: Grant Grundler , Matthew Wilcox , Jesse Barnes , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , Andrew Morton , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH] pci: print out DMA mask info Message-ID: <20081012071157.GA20056@colo.lackof.org> References: <1223506943-6543-1-git-send-email-yinghai@kernel.org> <20081009211837.GC18444@colo.lackof.org> <48EE7745.2020603@kernel.org> <20081009213551.GC25780@parisc-linux.org> <86802c440810091451y4a3caceg1abaa75464c40a72@mail.gmail.com> <20081009225533.GB1914@colo.lackof.org> <48EE8E55.4000009@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48EE8E55.4000009@kernel.org> X-Home-Page: http://www.parisc-linux.org/ User-Agent: Mutt/1.5.16 (2007-06-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2092 Lines: 51 On Thu, Oct 09, 2008 at 04:05:57PM -0700, Yinghai Lu wrote: > Grant Grundler wrote: > > On Thu, Oct 09, 2008 at 02:51:32PM -0700, Yinghai Lu wrote: > >> On Thu, Oct 9, 2008 at 2:35 PM, Matthew Wilcox wrote: > >>> Why's that interesting to the sysadmin of the machine? To the driver > >>> writer, certainly. But what's the use of it to the people using the > >>> machine? > > ... > >> make linux kernel act like black box as other os? > > > > I don't understand your reply. > > If someone thinks linux is a black box, printing this message won't help them. > > > could find out easily why some driver doesn't set dma mask correctly. > like why > qlogic qla2xxx only set consistent to 64bit, > emulex lpfc not set consistent to 64bit I agree making the information available is a good idea. It's just not going to help anyone 99% of the time and isn't a requirement for booting the machine. > > > > "To flag use of bounce buffer or other suboptimal behaviors" could be debated. > > > > > > Regarding associating the output with other PCI messages, I'd hope the fact > > that the /sys entry is in the same directory as other sys files would be > > enough clue to associate those together. e.g.: > > grundler <2068>cd /sys/bus/pci/devices/0000\:01\:00.0/ > > grundler <2069>ls > > broken_parity_status driver@ irq resource0 subsystem_device > > bus@ enable local_cpus resource1 subsystem_vendor > > class i2c-0/ modalias resource3 uevent > > config i2c-1/ power/ rom vendor > > device i2c-2/ resource subsystem@ > > > > add dma_mask coherent_dma_mask here? Yes, if there is no other more obvious place. It's just a suggestion which I happen to think is better than adding more boot time messages. thanks, grant -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/