Date: Sun, 12 Oct 2008 10:58:42 +0200
From: Pierre Ossman <drzeus-mmc@drzeus.cx>
To: Ben Dooks <ben-linux@fluff.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@vger.kernel.org,
       Ben Dooks <ben-linux@fluff.org>
Subject: Re: [patch 2/5] s3cmci: cpufreq support
Message-ID: <20081012105842.2c327627@mjolnir.drzeus.cx>
In-Reply-To: <20081010103314.435915526@fluff.org.uk>
References: <20081010103221.551485781@fluff.org.uk>
	<20081010103314.435915526@fluff.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1234
Lines: 32

On Fri, 10 Oct 2008 11:32:23 +0100
Ben Dooks <ben-linux@fluff.org> wrote:

> +	host = container_of(nb, struct s3cmci_host, freq_transition);
> +	newclk = clk_get_rate(host->clk);
> +	mmc = host->mmc;
> +
> +	if ((val == CPUFREQ_PRECHANGE && host->clk_rate > newclk) ||
> +	    (val == CPUFREQ_POSTCHANGE && host->clk_rate < newclk)) {

Isn't this backwards? The goal should be to avoid overclocking the
card, so if the old clock (which I assume is clk_rate) is slower than
the new clock (newclk), then we should adjust before the change happens,
temporarily underclocking the card.

(and vice versa for when the old clock is faster than the new clock)

-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  rdesktop, core developer          http://www.rdesktop.org

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/