Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759243AbYJLN7p (ORCPT ); Sun, 12 Oct 2008 09:59:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752482AbYJLN7e (ORCPT ); Sun, 12 Oct 2008 09:59:34 -0400 Received: from mx2.redhat.com ([66.187.237.31]:45445 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752010AbYJLN7d (ORCPT ); Sun, 12 Oct 2008 09:59:33 -0400 Date: Sun, 12 Oct 2008 09:59:03 -0400 From: Jeff Layton To: "Steve French" Cc: rjw@sisk.pl, "David Miller" , netdev@vger.kernel.org, "samba-technical@lists.samba.org" , "linux-cifs-client@lists.samba.org" , cooldavid@cooldavid.org, LKML Subject: Re: [linux-cifs-client] Fwd: [PATCH] Fix CIFS compilation with CONFIG_KEYS unset Message-ID: <20081012095903.33427ee8@tleilax.poochiereds.net> In-Reply-To: <524f69650810120640v41778375wf0a7662e773da26f@mail.gmail.com> References: <200810121315.37203.rjw@sisk.pl> <524f69650810120640v41778375wf0a7662e773da26f@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 778 Lines: 22 On Sun, 12 Oct 2008 08:40:39 -0500 "Steve French" wrote: > Rafael and Guo-Fu, > The following change to address the compile error that you noted is > slightly different than what you suggested but should fix what you > found. > Actually, I like Adrian/Rafael's fix better. I think we should avoid cluttering up the code with #ifdef's where possible. key_put() already is a no-op when CONFIG_KEYS is disabled. We might as well do the same thing with key_revoke(). Cheers, -- Jeff Layton -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/