Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756275AbYJLRFz (ORCPT ); Sun, 12 Oct 2008 13:05:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753956AbYJLRFo (ORCPT ); Sun, 12 Oct 2008 13:05:44 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:33722 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753925AbYJLRFn (ORCPT ); Sun, 12 Oct 2008 13:05:43 -0400 From: "Rafael J. Wysocki" To: "Steve French" Subject: Re: [linux-cifs-client] Fwd: [PATCH] Fix CIFS compilation with CONFIG_KEYS unset Date: Sun, 12 Oct 2008 19:09:52 +0200 User-Agent: KMail/1.9.9 Cc: "Jeff Layton" , "David Miller" , netdev@vger.kernel.org, "samba-technical@lists.samba.org" , "linux-cifs-client@lists.samba.org" , cooldavid@cooldavid.org, LKML References: <200810121315.37203.rjw@sisk.pl> <524f69650810120953t2ec8100cpdddc3ddfce0406d9@mail.gmail.com> <524f69650810120957t1a81f23lf3fd75fee78e72c3@mail.gmail.com> In-Reply-To: <524f69650810120957t1a81f23lf3fd75fee78e72c3@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200810121909.53233.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1146 Lines: 24 On Sunday, 12 of October 2008, Steve French wrote: > On Sun, Oct 12, 2008 at 11:53 AM, Steve French wrote: > > On Sun, Oct 12, 2008 at 8:59 AM, Jeff Layton wrote: > >> On Sun, 12 Oct 2008 08:40:39 -0500 > >> "Steve French" wrote: > >> > >> Actually, I like Adrian/Rafael's fix better. I think we should avoid > >> cluttering up the code with #ifdef's where possible. key_put() already > >> is a no-op when CONFIG_KEYS is disabled. We might as well do the same > >> thing with key_revoke(). > > I don't think it matters much - but we probably shouldn't be > > overriding global functions. > > To clarify, I like fixing it in keys.h better than overriding it in > cifs, but in the meantime we need an ifdef in cifs until keys.h > changes. Well, adding an empty definition for key_revoke() in the !CONFIG_KEYS case makes sense anyway IMO. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/