Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755253AbYJLSr1 (ORCPT ); Sun, 12 Oct 2008 14:47:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754120AbYJLSrP (ORCPT ); Sun, 12 Oct 2008 14:47:15 -0400 Received: from ey-out-2122.google.com ([74.125.78.24]:41343 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754070AbYJLSrO (ORCPT ); Sun, 12 Oct 2008 14:47:14 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=cKvFel/gGFE/OERXdqOgLK9jdNxfB9tVQgHjmMfQ5eaS/R6A/s0dNKKnjR17DvRlgi a8YDEnMG/bM/otI0GZ8hux+ATF0u5x8v4+cirwUQdN4hBFJAouHDKll/7ek9IrH2U3Ln gHccGo8neL2Cfq4uVTHl4FYT168Xepsa6FNHs= Message-ID: <524f69650810121147j4ad79f77p348a3814b7f05d01@mail.gmail.com> Date: Sun, 12 Oct 2008 13:47:12 -0500 From: "Steve French" To: "Rafael J. Wysocki" Subject: Re: [linux-cifs-client] Fwd: [PATCH] Fix CIFS compilation with CONFIG_KEYS unset Cc: "Jeff Layton" , "David Miller" , netdev@vger.kernel.org, "samba-technical@lists.samba.org" , "linux-cifs-client@lists.samba.org" , cooldavid@cooldavid.org, LKML In-Reply-To: <200810121909.53233.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200810121315.37203.rjw@sisk.pl> <524f69650810120953t2ec8100cpdddc3ddfce0406d9@mail.gmail.com> <524f69650810120957t1a81f23lf3fd75fee78e72c3@mail.gmail.com> <200810121909.53233.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1277 Lines: 32 On Sun, Oct 12, 2008 at 12:09 PM, Rafael J. Wysocki wrote: > On Sunday, 12 of October 2008, Steve French wrote: >> On Sun, Oct 12, 2008 at 11:53 AM, Steve French wrote: >> > On Sun, Oct 12, 2008 at 8:59 AM, Jeff Layton wrote: >> >> On Sun, 12 Oct 2008 08:40:39 -0500 >> >> "Steve French" wrote: >> >> >> >> Actually, I like Adrian/Rafael's fix better. I think we should avoid >> >> cluttering up the code with #ifdef's where possible. key_put() already >> >> is a no-op when CONFIG_KEYS is disabled. We might as well do the same >> >> thing with key_revoke(). >> > I don't think it matters much - but we probably shouldn't be >> > overriding global functions. >> >> To clarify, I like fixing it in keys.h better than overriding it in >> cifs, but in the meantime we need an ifdef in cifs until keys.h >> changes. > > Well, adding an empty definition for key_revoke() in the !CONFIG_KEYS case > makes sense anyway IMO. I agree. ACKED -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/