Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755599AbYJMD72 (ORCPT ); Sun, 12 Oct 2008 23:59:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754436AbYJMD7U (ORCPT ); Sun, 12 Oct 2008 23:59:20 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:47107 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753080AbYJMD7T (ORCPT ); Sun, 12 Oct 2008 23:59:19 -0400 Date: Sun, 12 Oct 2008 20:58:54 -0700 (PDT) Message-Id: <20081012.205854.227501807.davem@davemloft.net> To: petr@vandrovec.name Cc: ivecera@redhat.com, romieu@fr.zoreil.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fix NULL pointer dereference on r8169 load From: David Miller In-Reply-To: <20081012081352.GA29794@vana.vc.cvut.cz> References: <20081012081352.GA29794@vana.vc.cvut.cz> X-Mailer: Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 695 Lines: 18 From: Petr Vandrovec Date: Sun, 12 Oct 2008 10:13:52 +0200 > From: Petr Vandrovec > > mmio_addr in r8169 needs to be initialized before use > > Maybe that all tp-> initialization should be moved before rtl_init_mac_address call, > but this is enough to get rid of crash in rtl_rar_set due to mmio_addr being uninitialized. > > Signed-off-by: Petr Vandrovec Applied, thanks Petr. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/