Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756923AbYJMOgM (ORCPT ); Mon, 13 Oct 2008 10:36:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754757AbYJMOf4 (ORCPT ); Mon, 13 Oct 2008 10:35:56 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:48535 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754519AbYJMOfz (ORCPT ); Mon, 13 Oct 2008 10:35:55 -0400 Message-ID: <48F378C6.7030206@linux-foundation.org> Date: Mon, 13 Oct 2008 09:35:18 -0700 From: Christoph Lameter User-Agent: Thunderbird 2.0.0.17 (X11/20080925) MIME-Version: 1.0 To: Miklos Szeredi CC: penberg@cs.helsinki.fi, nickpiggin@yahoo.com.au, hugh@veritas.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: Re: SLUB defrag pull request? References: <1223883004.31587.15.camel@penberg-laptop> <1223883164.31587.16.camel@penberg-laptop> <200810132354.30789.nickpiggin@yahoo.com.au> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 850 Lines: 20 Miklos Szeredi wrote: > And the things kick_inodes() does without any sort of locking look > even more dangerous. > > It should be the other way round: first make sure nothing is > referencing the inode, and _then_ start cleaning it up with > appropriate locks held. See prune_icache(). > > kick_inodes() only works on inodes that first have undergone get_inodes() where we establish a refcount under inode_lock(). The final cleanup in kick_inodes() is done under iprune_mutex. You are looking at the loop that does writeback and invalidates attached dentries. This can fail for various reasons. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/