Date: Mon, 13 Oct 2008 10:45:11 -0400
From: Arjan van de Ven <arjan@infradead.org>
To: "Pekka Enberg" <penberg@cs.helsinki.fi>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, mingo@elte.hu
Subject: Re: [PATCH] fastboot: Introduce an asynchronous function call
 mechanism
Message-ID: <20081013104511.477b0614@infradead.org>
In-Reply-To: <84144f020810130015j2905e568mb5819c4d4bf27279@mail.gmail.com>
References: <20081012194427.2e21c22e@infradead.org>
	<84144f020810130015j2905e568mb5819c4d4bf27279@mail.gmail.com>
Organization: Intel
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1087
Lines: 36

On Mon, 13 Oct 2008 10:15:03 +0300
"Pekka Enberg" <penberg@cs.helsinki.fi> wrote:

> Hi Arjan,
> 
> On Mon, Oct 13, 2008 at 2:44 AM, Arjan van de Ven
> <arjan@infradead.org> wrote:
> > +void call_async(int pool_number, int argc, ...)
> > +{
> > +       struct async_item *item;
> > +       va_list ap;
> > +
> > +       if (argc > 4 || argc < 0) {
> > +               WARN(1, KERN_ERR "Too many arguments to async
> > function! Skipping...\n");
> > +               return;
> > +       }
> > +
> > +       item = kmalloc(sizeof(struct async_item), GFP_ATOMIC);
> 
> Why is there no check for NULL here?


because at 35000 feet it won't return NULL ;-)

but yeah thanks for spotting, I'll fix it.

-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/