Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757747AbYJMQtS (ORCPT ); Mon, 13 Oct 2008 12:49:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755159AbYJMQtI (ORCPT ); Mon, 13 Oct 2008 12:49:08 -0400 Received: from gate.crashing.org ([63.228.1.57]:44651 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755132AbYJMQtG (ORCPT ); Mon, 13 Oct 2008 12:49:06 -0400 Cc: Dave Jones , Linux Kernel , linuxppc-dev@ozlabs.org Message-Id: <141BB874-FDA4-4107-BEF6-15B84023E44B@kernel.crashing.org> From: Kumar Gala To: avorontsov@ru.mvista.com In-Reply-To: <20081009003259.GA8373@oksana.dev.rtsoft.ru> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v929.2) Subject: Re: [PATCH] powerpc: fix fsl_upm nand driver modular build Date: Mon, 13 Oct 2008 11:48:38 -0500 References: <20081008222815.GA20542@redhat.com> <20081008230219.GA8075@oksana.dev.rtsoft.ru> <20081008233306.GA31771@redhat.com> <20081009003259.GA8373@oksana.dev.rtsoft.ru> X-Mailer: Apple Mail (2.929.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 982 Lines: 33 On Oct 8, 2008, at 7:32 PM, Anton Vorontsov wrote: > The fsl_upm nand driver fails to build because fsl_lbc_lock isn't > exported, the lock is needed by the inlined fsl_upm_run_pattern() > function: > > ERROR: "fsl_lbc_lock" [drivers/mtd/nand/fsl_upm.ko] undefined! > > Dave Jones purposed to export the lock, but it is better to just > uninline > the fsl_upm_run_pattern(). > > When uninlined we also no longer need the exported fsl_lbc_regs, and > both fsl_lbc_lock and fsl_lbc_regs could be marked static. > > While at it, also add some missing includes that we should have > included > explicitly. > > Reported-by: Dave Jones > Signed-off-by: Anton Vorontsov > --- applied. - k -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/