Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761072AbYJMSwm (ORCPT ); Mon, 13 Oct 2008 14:52:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753609AbYJMSwa (ORCPT ); Mon, 13 Oct 2008 14:52:30 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:36109 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753170AbYJMSw3 (ORCPT ); Mon, 13 Oct 2008 14:52:29 -0400 Date: Mon, 13 Oct 2008 11:52:05 -0700 (PDT) Message-Id: <20081013.115205.31287539.davem@davemloft.net> To: afleming@freescale.com Cc: bunk@kernel.org, buytenh@marvell.com, jgarzik@pobox.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org Subject: Re: [2.6 patch] export genphy_restart_aneg From: David Miller In-Reply-To: <5281FCAB-128C-4AE7-8241-BF748B1911CF@freescale.com> References: <20081013171900.GK29938@cs181140183.pp.htv.fi> <5281FCAB-128C-4AE7-8241-BF748B1911CF@freescale.com> X-Mailer: Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1002 Lines: 33 From: Andy Fleming Date: Mon, 13 Oct 2008 13:04:30 -0500 > > On Oct 13, 2008, at 12:19, Adrian Bunk wrote: > > > This patch fixes the following build error caused by > > commit ed94493fb38a665cebcf750dfabe8a6dd13e136f > > (mv643xx_eth: convert to phylib): > > > > <-- snip --> > > > > ... > > Building modules, stage 2. > > MODPOST 1280 modules > > ERROR: "genphy_restart_aneg" [drivers/net/mv643xx_eth.ko] undefined! > > ... > > make[2]: *** [__modpost] Error 1 > > > > <-- snip --> > > > > > > Signed-off-by: Adrian Bunk > > > Could you get genphy_setup_forced, too? It doesn't appear to be used, but it's currently in include/linux/phy.h, and not static. When there is a use we can add the export. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/