Message-ID: <48F3AFBF.3040201@firstfloor.org>
Date: Mon, 13 Oct 2008 22:29:51 +0200
From: Andi Kleen <andi@firstfloor.org>
User-Agent: Thunderbird 1.5.0.14 (X11/20060911)
MIME-Version: 1.0
To: Robert Richter <robert.richter@amd.com>
CC: linux-kernel@vger.kernel.org, oprofile-list@lists.sourceforge.net,
       Ingo Molnar <mingo@elte.hu>
Subject: Re: Please pull arch perfmon update
References: <20080929235253.GA31074@one.firstfloor.org> <20081013183556.GD23557@erda.amd.com>
In-Reply-To: <20081013183556.GD23557@erda.amd.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1015
Lines: 29


> 
> I applied your patches to the x86-oprofile-for-tip branch of
> git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile.git

Will that still make 2.6.28?

> I added a follow on patch (446223f) on branch arch-perfmon that

I didn't do that intentionally because it's called too late.
The function really has to be called early, so that the fallback
works.

> There is one question to patch "oprofile: discover counters for op
> ppro too". arch_perfmon_setup_counters() is actually never called for
> ppro, so there is no code that changes the numbers in
> op_ppro_spec. The patch as it is has no effect (except then loading
> additional module code).

Ah true, i must have deleted one hunk too much while refactoring.
It's ok to drop this patch for now.

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/