Date: Mon, 13 Oct 2008 14:22:13 -0700 (PDT)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
cc: Andrew Morton <akpm@linux-foundation.org>,
       linux-scsi <linux-scsi@vger.kernel.org>,
       linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PATCH] intermediate SCSI updates
In-Reply-To: <1223925606.5566.20.camel@localhost.localdomain>
Message-ID: <alpine.LFD.2.00.0810131416410.3288@nehalem.linux-foundation.org>
References: <1223909115.5566.13.camel@localhost.localdomain>  <alpine.LFD.2.00.0810131017030.3288@nehalem.linux-foundation.org> <1223925606.5566.20.camel@localhost.localdomain>
User-Agent: Alpine 2.00 (LFD 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1704
Lines: 43


On Mon, 13 Oct 2008, James Bottomley wrote:
> 
> Not exactly.  It has to be rebased to run as a postmerge tree, but it
> does get tested by me (admittedly on my limited set of machines, which
> don't include any actual devices that do block integrity) every time I
> rebase.

What I'm upset about is that this has apparently gotten not even some 
trivial testing of the _default_ build. I'm not talking about any odd 
config options here. I'm literally talking about the only _sane_ config 
option case.

You yourself admit that even you don't have any actual devices that can 
support the block integrity stuff, yet you have apparently only compile- 
tested the insane case of still enabling that thing and apparently nobody 
else has bothered either.

Was this in linux-next?

Is linux-next coverage REALLY so weak that it doesn't even test the 
default config options, much less any random options? What's the point of 
linux-next then?

Again, the date on that thing is claimed to be September 19th, although it 
was obviously committed later.

> However, does this work for you?  It fixes the problem for me.

I could trivially have fixed the compile issue. That's not what upsets me. 
What upsets me is that this set of patches apparently had almost nobody 
looking at them at all before they got sent to me.

If it was some odd and unusual config option, I'd be less upset. hey, 
stuff happens. But it sure as heck was nothing of the sort!

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/