Date: Mon, 13 Oct 2008 18:40:20 -0700 (PDT)
Message-Id: <20081013.184020.193699133.davem@davemloft.net>
To: cooldavid@cooldavid.org
Cc: kamalesh@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
       apw@shadowen.org, jgarzik@redhat.com, ron.mercer@qlogic.com,
       scofeldm@cisco.com
Subject: Re: [PATCH] 2.6.27-git2 - fix build error at csum_ipv6_magic()
From: David Miller <davem@davemloft.net>
In-Reply-To: <20081013192101.M74635@cooldavid.org>
References: <20081013121441.GB14372@linux.vnet.ibm.com>
	<20081013192101.M74635@cooldavid.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1029
Lines: 24

From: "Guo-Fu Tseng" <cooldavid@cooldavid.org>
Date: Tue, 14 Oct 2008 03:28:14 +0800

> But since <net/ip6_checksum.h> compensate the lack of
> `csum_ipv6_magic` function defined in <asm/checksum.h>
> of some architecture, should <net/ip6_checksum.h> be
> included in <net/checksum.h> as well?

No, the standard convention is that if you need to call this
ipv6 checksumming routine you include net/ip6_checksum.h
From: "Guo-Fu Tseng" <cooldavid@cooldavid.org>
Date: Tue, 14 Oct 2008 03:28:14 +0800

> BTW, if there is a patch against jme driver which I maintain,
> and I just simply agree with it, should I silently noticed that
> and let someone like Jeff or David to review/apply it,
> or should I reply an ack of it?

You can ACK it and I usually apply patches like this directly.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/