Message-ID: <48F409E9.3030501@zytor.com>
Date: Mon, 13 Oct 2008 19:54:33 -0700
From: "H. Peter Anvin" <hpa@zytor.com>
User-Agent: Thunderbird 2.0.0.16 (X11/20080723)
MIME-Version: 1.0
To: benh@kernel.crashing.org
CC: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
       yhlu.kernel@gmail.com
Subject: Re: [PATCH] Fix broken debug output reserve_region_with_split()
References: <20081014005428.EC2D8DDF93@ozlabs.org>	 <48F3F014.3050406@zytor.com> <1223948488.8157.309.camel@pasglop>
In-Reply-To: <1223948488.8157.309.camel@pasglop>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 885
Lines: 22

Benjamin Herrenschmidt wrote:
>>>
>> I really think Linus' solution (add a resource printf modifier, that can 
>> contain the whole format) is much better.
> 
> I agree. In fact I may even have a patch somewhere for that. 
> 
> It has to be a pointer tho, thus what do we want ? Something that takes
> a pointer to a resource_size_t or to a whole struct resource ? In the
> later case, do we want to print the whole flags too ?
> 

Linus already posted a patch.  He took a struct resource
and printed it as a range.  I pointed out that we should use the flags 
to determine formatting options, e.g. I/O space is only 16 bits on x86.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/