Subject: Re: [PROBLEM] hard-lock with kmemtrace, relayfs, and splice
From: Tom Zanussi <zanussi@comcast.net>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>,
       jens.axboe@oracle.com, linux-kernel@vger.kernel.org
In-Reply-To: <1223881068.31587.1.camel@penberg-laptop>
References: <20080923212914.GB5237@localhost>
	 <1223386477.28348.42.camel@penberg-laptop>
	 <1223623191.8959.26.camel@penberg-laptop>
	 <1223628687.8959.37.camel@penberg-laptop>
	 <1223629803.8959.40.camel@penberg-laptop>
	 <1223631723.8959.46.camel@penberg-laptop>
	 <1223701131.7489.25.camel@charm-linux>
	 <1223881068.31587.1.camel@penberg-laptop>
Content-Type: text/plain
Date: Mon, 13 Oct 2008 23:03:51 -0500
Message-Id: <1223957031.10883.7.camel@charm-linux>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1980
Lines: 66

Hi Pekka,

On Mon, 2008-10-13 at 09:57 +0300, Pekka Enberg wrote:
> Hi Tom,
> 
> On Fri, 2008-10-10 at 23:58 -0500, Tom Zanussi wrote:
> > It looks like you hit the same problem as described here:
> > 
> > commit 8191ecd1d14c6914c660dfa007154860a7908857
> > 
> >     splice: fix infinite loop in generic_file_splice_read()
> > 
> > relay uses the same loop but it never got noticed or fixed.  Can you try
> > the following patch:
> > 
> > diff --git a/kernel/relay.c b/kernel/relay.c
> > index 8d13a78..6a4d439 100644
> > --- a/kernel/relay.c
> > +++ b/kernel/relay.c
> > @@ -1318,12 +1318,9 @@ static ssize_t relay_file_splice_read(struct file *in,
> >  		if (ret < 0)
> >  			break;
> >  		else if (!ret) {
> > -			if (spliced)
> > -				break;
> > -			if (flags & SPLICE_F_NONBLOCK) {
> > +			if (flags & SPLICE_F_NONBLOCK)
> >  				ret = -EAGAIN;
> > -				break;
> > -			}
> > +			break;
> >  		}
> >  
> >  		*ppos += ret;
> > 
> 
> Indeed. That fixes the deadlock.
> 
> However, now I don't get anything to the cpu*.out files if I run
> kmemtraced with kmemtrace disabled. If I enable kmemtrace manually and
> then run kmemtraced, I do receive some data. I did apply the
> kmemtrace-user patch as well.
> 
> Hmm?

To me, that sounds like how it should work - if kmemtrace is disabled,
it shouldn't be logging anything, and that's in fact what I saw when
debugging this - it started out disabled and therefore nothing being
logged to relay (printks confirmed that).  When I wrote 1 to the enabled
file, data started getting logged to relay and to the *.out files.

So I don't know why the enabled state behaves the way it does, or if
it's unexpected, but that anyway doesn't seem like a relay problem to
me.

Tom

> 
> 		Pekka
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/