Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752857AbYJNSBW (ORCPT ); Tue, 14 Oct 2008 14:01:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751388AbYJNSBO (ORCPT ); Tue, 14 Oct 2008 14:01:14 -0400 Received: from ug-out-1314.google.com ([66.249.92.170]:11073 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751370AbYJNSBN (ORCPT ); Tue, 14 Oct 2008 14:01:13 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=jO2XlWjwpFDwYM5JYqDUDZgGvUNQr6cSVRJ6Z1MwbZN0YObQa9a46oqxvicmijeGPd TnPjdVRtea3RBaKKFfoMVXp6SGdRnBRVyAuAQyOMVGQHG8ilnwrBJIKWOZtg51CcTnTr GR+T09DyhaNS6lmlHi4w4ZaWJTDgMI9Mhvb4w= Date: Tue, 14 Oct 2008 20:00:06 +0200 From: Marcin Slusarz To: "H. Peter Anvin" Cc: James Bottomley , Linux Kernel Mailing List , linux-scsi , James Bottomley Subject: Re: Checkin 7404ad3b6d04efbd918e9e2e776bf560fbedf47d breaks boot on KVM Message-ID: <20081014175901.GA5584@joi> References: <48F3E1C9.6030007@zytor.com> <1223990609.12440.8.camel@localhost.localdomain> <48F4C237.2060103@zytor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48F4C237.2060103@zytor.com> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2138 Lines: 51 On Tue, Oct 14, 2008 at 09:00:55AM -0700, H. Peter Anvin wrote: > James Bottomley wrote: >> Actually, it is surprising. That patch takes the default arithmetic for >> calculating the disk size out of sd and uses a routine to do it more >> efficiently in lib/string_helpers.c >> So there are two problems: Why does it panic on revert (could you post >> the oops) and what does kvm object to in string_get_size ... it's a >> fairly innocuous routine as I read it ... your symptoms sound like the >> for loop isn't terminating. > > Here is the oops. Note that it does get well past the hang point before it > crashes. It is 100% reproducible. > > (...) > BUG: spinlock bad magic on CPU#0, swapper/1 > lock: c0b75418, .magic: 00000000, .owner: /-1, .owner_cpu: 0 > Pid: 1, comm: swapper Not tainted 2.6.27 #17 > Call Trace: > [] ? printk+0xf/0x17 > [] spin_bug+0x75/0x80 > [] _raw_spin_lock+0x1e/0xe4 > [] ? serial8250_startup+0x33e/0x4e5 > [] _spin_lock_irq+0x32/0x3a > [] ? serial8250_startup+0x33e/0x4e5 > [] serial8250_startup+0x33e/0x4e5 > [] uart_startup+0x84/0x143 > [] uart_open+0x14b/0x381 > [] ? _spin_unlock+0x27/0x3c > [] ? check_tty_count+0x3b/0x8a > [] tty_open+0x263/0x366 > [] chrdev_open+0x168/0x180 > [] __dentry_open+0x146/0x234 > [] nameidata_to_filp+0x1f/0x33 > [] ? chrdev_open+0x0/0x180 > [] do_filp_open+0x342/0x659 > [] ? trace_hardirqs_off+0xb/0xd > [] ? _spin_unlock+0x27/0x3c > [] do_sys_open+0x42/0xb7 > [] sys_open+0x1e/0x26 > [] init_post+0x2a/0x13c > [] ? kernel_thread_helper+0x7/0x10 It's a different issue. See: http://lkml.org/lkml/2008/10/13/470 and http://lkml.org/lkml/2008/10/13/474 Marcin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/