Date: Tue, 14 Oct 2008 12:41:44 -0700 (PDT)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jiri Kosina <jkosina@suse.cz>
cc: linux-kernel@vger.kernel.org, Jiri Slaby <jirislaby@gmail.com>
Subject: Re: [GIT] HID patches for 2.6.28
In-Reply-To: <alpine.LNX.1.10.0810140055060.26779@jikos.suse.cz>
Message-ID: <alpine.LFD.2.00.0810141236590.3288@nehalem.linux-foundation.org>
References: <alpine.LNX.1.10.0810140055060.26779@jikos.suse.cz>
User-Agent: Alpine 2.00 (LFD 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=ISO-8859-7
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1128
Lines: 33


On Tue, 14 Oct 2008, Jiri Kosina wrote:
> 
> could you please pull from 'for-linus' branch of
> 
>         git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-linus
> 
> to receive 2.6.28 patches for the HID (the HIDeously slow devices, you 
> know) code.

This is really HIDeous. Disgusting.

The new Kconfig options are almost uselessly described, and very annoying 
and this adds several new warnings of the type:

	drivers/hid/hid-lg.c:342: warning: ?hid_compat_logitech? defined but not used

which is just unacceptable.

I have an entirely warningless build. I'm not going to break that over 
something like this. Not pulled. Please fix.

As to the Kconfig options - do they really add so much space that you need 
to ask for the quirks? You didn't use to. Can you make the questions 
depend on EMBEDDED, or at least on the HID_COMPAT thing or whatever?

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/