Date: Tue, 14 Oct 2008 15:49:16 -0700 (PDT)
Message-Id: <20081014.154916.232117559.davem@davemloft.net>
To: sven.wegener@stealer.net
Cc: adobriyan@gmail.com, davej@redhat.com, linux-kernel@vger.kernel.org,
       cpufreq@vger.kernel.org
Subject: Re: sparc64 allmodconfig build failure...
From: David Miller <davem@davemloft.net>
In-Reply-To: <alpine.LNX.2.00.0810141434030.13897@titan.stealer.net>
References: <alpine.LNX.2.00.0810140945060.13897@titan.stealer.net>
	<20081014120605.GB23213@x200.localdomain>
	<alpine.LNX.2.00.0810141434030.13897@titan.stealer.net>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1007
Lines: 22

From: Sven Wegener <sven.wegener@stealer.net>
Date: Tue, 14 Oct 2008 23:08:17 +0200 (CEST)

> Yeah, with the default governor being any of supported governors, we
> either need some ugly #ifdef mess to only export the governor that
> is selected or just revert to the old code, which unconditionally
> exports all governors. Or something like the patch below. With the
> additional modules that I oversaw and that require the export, I'm
> fine with just reverting the commit, although I think that
> encapsulating the default governor decision in a built-in function
> is cleaner than having modules reference different symbols depending
> on configuration.

Personally I prefer the revert.

All of the alternative solutions shown far have been extremely
ugly.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/