Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752136AbYJOFGP (ORCPT ); Wed, 15 Oct 2008 01:06:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751046AbYJOFF7 (ORCPT ); Wed, 15 Oct 2008 01:05:59 -0400 Received: from smtp6.pp.htv.fi ([213.243.153.40]:53498 "EHLO smtp6.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750973AbYJOFF6 (ORCPT ); Wed, 15 Oct 2008 01:05:58 -0400 Date: Wed, 15 Oct 2008 08:05:57 +0300 From: Adrian Bunk To: Jiri Slaby , Jiri Kosina , Mauro Carvalho Chehab Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: usbhid_set_leds problems Message-ID: <20081015050557.GB20183@cs181140183.pp.htv.fi> References: <20081015041346.GE4710@cs181140183.pp.htv.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20081015041346.GE4710@cs181140183.pp.htv.fi> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1644 Lines: 45 On Wed, Oct 15, 2008 at 07:13:46AM +0300, Adrian Bunk wrote: > With CONFIG_USB_HID=n I'm getting the following build error: > > <-- snip --> > > ... > LD .tmp_vmlinux1 > drivers/built-in.o: In function `bright_probe': > drivers/hid/hid-bright.c:38: undefined reference to `usbhid_set_leds' > drivers/hid/hid-bright.c:38: undefined reference to `usbhid_set_leds' > drivers/built-in.o: In function `dell_probe': > drivers/hid/hid-dell.c:41: undefined reference to `usbhid_set_leds' > drivers/hid/hid-dell.c:41: undefined reference to `usbhid_set_leds' > drivers/built-in.o: In function `lg_probe': > drivers/hid/hid-lg.c:252: undefined reference to `usbhid_set_leds' > drivers/hid/hid-lg.c:252: more undefined references to `usbhid_set_leds' follow > ... > make[1]: *** [.tmp_vmlinux1] Error 1 > > <-- snip --> > > > And I'm not sure commit 6edfa8dc33803a49ad936ead9840e453bee6ca3b > (HID: move reset leds quirk) was a good idea at all since I don't > see cases like HID_DELL=y, CONFIG_USB_HID=m could now work at all. Scrap that mail, I shouldn't send patches before the first cup of tea... I just found the actual problem. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/