Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752974AbYJOID3 (ORCPT ); Wed, 15 Oct 2008 04:03:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750999AbYJOIDL (ORCPT ); Wed, 15 Oct 2008 04:03:11 -0400 Received: from rv-out-0506.google.com ([209.85.198.232]:49572 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750853AbYJOIDI (ORCPT ); Wed, 15 Oct 2008 04:03:08 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=io70Cb8R6t+1USnPMI9aghKA1Tlg8dIi/XZB1w4Deb1FTx0Xb+JLmlruvcjOaVFSP9 xx/IBEqx/NH4nF8n3w/PhkUwYdSD6+PBOnozjUroWFlZ+Mz0iG519IEdBtckC2mTkckB YjJxvoqGJUER/tk61NcaAORUg3071JdmGxqTY= Message-ID: Date: Wed, 15 Oct 2008 17:03:07 +0900 From: "Magnus Damm" To: "Guennadi Liakhovetski" Subject: Re: [PATCH] soc-camera: fix compile breakage on SH Cc: "Adrian Bunk" , "Stefan Herbrechtsmeier" , "Mauro Carvalho Chehab" , lethal@linux-sh.org, linux-sh@vger.kernel.org, video4linux-list@redhat.com, linux-kernel@vger.kernel.org, "Magnus Damm" In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20081014183936.GB4710@cs181140183.pp.htv.fi> <20081015033303.GC4710@cs181140183.pp.htv.fi> <20081015052026.GC20183@cs181140183.pp.htv.fi> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1329 Lines: 33 Hi Guennadi, On Wed, Oct 15, 2008 at 3:41 PM, Guennadi Liakhovetski wrote: > Hi Magnus > > On Wed, 15 Oct 2008, Magnus Damm wrote: > >> Thanks for working on fixing the breakage. I'd prefer to wait a bit >> since there are quite a few pinmux patches queued up that may break if >> we merge a fix right now. I can fix it up later on. > > no, I would not leave the kernel in a non-compilable state even if just > for one board. Please, test a new version of the patch below. And yes, You > will have to rebase your patches, sorry. Another thing, could you also, > please, add a license / copyright header to > include/media/soc_camera_platform.h? I'm not asking you to keep the board broken forever. It's just a question of in which order the trees are getting merged. Again, I'd rather see that this fix is put _on_top_ of the patches that are already queued up in the SuperH tree. Merging it before doesn't help anything in my opinion - especially since the change should go though the SuperH tree anyway. Feel free to add any header you like. =) / magnus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/