Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753135AbYJOKEV (ORCPT ); Wed, 15 Oct 2008 06:04:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750954AbYJOKEM (ORCPT ); Wed, 15 Oct 2008 06:04:12 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:33243 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750879AbYJOKEL (ORCPT ); Wed, 15 Oct 2008 06:04:11 -0400 Date: Wed, 15 Oct 2008 12:02:52 +0200 From: Ingo Molnar To: Jiri Kosina Cc: Jean Delvare , Linus Torvalds , linux-kernel@vger.kernel.org, Jiri Slaby , Adrian Bunk , Vegard Nossum Subject: Re: [GIT] HID patches for 2.6.28 Message-ID: <20081015100252.GA26296@elte.hu> References: <20081015093636.GB19403@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00,DNS_FROM_SECURITYSAGE autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] 0.0 DNS_FROM_SECURITYSAGE RBL: Envelope sender in blackholes.securitysage.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1460 Lines: 38 * Jiri Kosina wrote: > On Wed, 15 Oct 2008, Ingo Molnar wrote: > > > this or the I2C updates cause widespread build failures in latest -git: > > For the usbhid_set_leds(), Adrian has already sent me a fix [1]. > Still, I would like to understand whether this failure is bug or > feature in select/depends handling in Kconfig, because it seems to > behave differently from what I was expecting. yes, it's a kconfig bug: Kconfig must either not allow complex selects (during its initial parsing pass of the Kconfig dependnecy tree) or handle the dependencies correctly. The current "allow them silently and pepper the kernel with build errors" approach is obviously silly. We already have over 100 bugfixes in the tree from the past 3 years due to kconfig's inability to figure out the correct dependencies. (count: rising steadily) Changes to the Kconfig tool to address this design bug did not get picked up. See for example this quick patch from Vegard half a year ago: http://lkml.org/lkml/2008/5/4/13 that patch was not adopted and the config options in the warning log were later on frequent participants in build failures and subsequent stream of trivial fixes. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/